From 06846919938d2c6e8c54a62b38567db4e73bd9d5 Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Wed, 1 Oct 2025 12:35:57 -0400 Subject: [PATCH] fix crash if ServerService is disposed before being started --- packages/backend/src/server/ServerService.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/server/ServerService.ts b/packages/backend/src/server/ServerService.ts index 4dfc1c8050..a25505f813 100644 --- a/packages/backend/src/server/ServerService.ts +++ b/packages/backend/src/server/ServerService.ts @@ -40,7 +40,7 @@ const _dirname = fileURLToPath(new URL('.', import.meta.url)); @Injectable() export class ServerService implements OnApplicationShutdown { private logger: Logger; - #fastify: FastifyInstance; + #fastify?: FastifyInstance; constructor( @Inject(DI.config) @@ -316,7 +316,7 @@ export class ServerService implements OnApplicationShutdown { await this.streamingApiServerService.detach(); this.logger.info('Disconnecting HTTP clients....;'); - await this.#fastify.close(); + await this.#fastify?.close(); this.logger.info('Server disposed.'); } @@ -325,6 +325,9 @@ export class ServerService implements OnApplicationShutdown { * Get the Fastify instance for testing. */ public get fastify(): FastifyInstance { + if (!this.#fastify) { + throw new Error('Cannot get fastify before starting server'); + } return this.#fastify; }