From 0cc839da8a6a10d6d9856a032a84d5b2f7000ca0 Mon Sep 17 00:00:00 2001
From: Hazelnoot <acomputerdog@gmail.com>
Date: Sun, 14 Sep 2025 09:01:57 -0400
Subject: [PATCH] improve logging for edge cases in refetchPublicKeyForApId

---
 .../src/core/activitypub/ApDbResolverService.ts        | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/backend/src/core/activitypub/ApDbResolverService.ts b/packages/backend/src/core/activitypub/ApDbResolverService.ts
index 30eb45433e..4fdc331e7e 100644
--- a/packages/backend/src/core/activitypub/ApDbResolverService.ts
+++ b/packages/backend/src/core/activitypub/ApDbResolverService.ts
@@ -144,14 +144,18 @@ export class ApDbResolverService implements OnApplicationShutdown {
 		await this.apPersonService.updatePerson(user.uri);
 		const newKey = await this.apPersonService.findPublicKeyByUserId(user.id);
 
-		if (newKey) {
-			if (oldKey && newKey.keyPem === oldKey.keyPem) {
+		if (newKey && oldKey) {
+			if (newKey.keyPem === oldKey.keyPem) {
 				this.apLoggerService.logger.debug(`Public key is up-to-date for user ${user.id} (${user.uri})`);
 			} else {
 				this.apLoggerService.logger.info(`Updated public key for user ${user.id} (${user.uri})`);
 			}
+		} else if (newKey) {
+			this.apLoggerService.logger.info(`Registered public key for user ${user.id} (${user.uri})`);
+		} else if (oldKey) {
+			this.apLoggerService.logger.info(`Deleted public key for user ${user.id} (${user.uri})`);
 		} else {
-			this.apLoggerService.logger.warn(`Failed to update public key for user ${user.id} (${user.uri})`);
+			this.apLoggerService.logger.warn(`Could not find any public key for user ${user.id} (${user.uri})`);
 		}
 
 		return newKey ?? oldKey;