misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix timer leak in SkRateLimiterService

Browse source
This commit is contained in:
Hazelnoot 2025-09-16 11:28:26 -04:00
parent f6e1b40fd8
commit 0f2e809229
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/backend/src/server/SkRateLimiterService.ts
View file

@ -13,6 +13,7 @@ import { RoleService } from '@/core/RoleService.js';
import { CacheManagementService, type ManagedMemoryKVCache } from '@/global/CacheManagementService.js'; import { CacheManagementService, type ManagedMemoryKVCache } from '@/global/CacheManagementService.js';
import { ConflictError } from '@/misc/errors/ConflictError.js'; import { ConflictError } from '@/misc/errors/ConflictError.js';
import { DI } from '@/di-symbols.js'; import { DI } from '@/di-symbols.js';
import { bindThis } from '@/decorators.js';
// Sentinel value used for caching the default role template. // Sentinel value used for caching the default role template.
// Required because MemoryKVCache doesn't support null keys. // Required because MemoryKVCache doesn't support null keys.
@ -64,6 +65,7 @@ export class SkRateLimiterService {
* @param limit The limit definition * @param limit The limit definition
* @param actorOrUser authenticated client user or IP hash * @param actorOrUser authenticated client user or IP hash
*/ */
@bindThis
public async limit(limit: Keyed<RateLimit>, actorOrUser: string | MiUser): Promise<LimitInfo> { public async limit(limit: Keyed<RateLimit>, actorOrUser: string | MiUser): Promise<LimitInfo> {
if (this.disabled) { if (this.disabled) {
return disabledLimitInfo; return disabledLimitInfo;

4
packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts
View file

@ -67,6 +67,10 @@ describe(SkRateLimiterService, () => {
mockEnvService.env.NODE_ENV = 'production'; mockEnvService.env.NODE_ENV = 'production';
}); });
afterEach(() => {
serviceUnderTest().dispose();
});
describe('limit', () => { describe('limit', () => {
const actor = 'actor'; const actor = 'actor';
const key = 'test'; const key = 'test';