misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

add error handler for ws library

Browse source
This commit is contained in:
Hazelnoot 2025-08-15 16:19:05 -04:00
parent 57450fd8b8
commit 49eb26694a
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packages/backend/src/server/api/StreamingApiServerService.ts
View file

@ -105,6 +105,10 @@ export class StreamingApiServerService implements OnApplicationShutdown {
perMessageDeflate: this.config.websocketCompression,
});
// ws library will kill the process if we don't catch unhandled exceptions.
// https://github.com/websockets/ws/issues/1354#issuecomment-1343117738
this.#wss.on('error', this.onWsError);
server.on('upgrade', async (request, socket, head) => {
if (request.url == null) {
socket.write('HTTP/1.1 400 Bad Request\r\n\r\n');
@ -307,6 +311,7 @@ export class StreamingApiServerService implements OnApplicationShutdown {
this.#connections.clear();
this.#connectionsByClient.clear();
this.#wss.off('error', this.onWsError);
await new Promise<void>((resolve, reject) => {
this.#wss.close(err => {
@ -315,4 +320,10 @@ export class StreamingApiServerService implements OnApplicationShutdown {
});
});
}
@bindThis
private async onWsError(error: unknown) {
this.#logger.error(`Unhandled error in streaming api: ${renderInlineError(error)}`);
this.#logger.debug('Error details:', { error });
}
}