misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

make sure S3 clients are properly disposed

Browse source
This commit is contained in:
Hazelnoot 2025-09-28 10:59:48 -04:00
parent db4661397b
commit 4d9317ad2b
4 changed files with 112 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

29
packages/backend/test/unit/S3Service.ts
View file

@ -14,28 +14,37 @@ import {
UploadPartCommand,
} from '@aws-sdk/client-s3';
import { mockClient } from 'aws-sdk-client-mock';
import { FakeInternalEventService } from '../misc/FakeInternalEventService.js';
import type { TestingModule } from '@nestjs/testing';
import { GlobalModule } from '@/GlobalModule.js';
import { CoreModule } from '@/core/CoreModule.js';
import { S3Service } from '@/core/S3Service.js';
import { MiMeta } from '@/models/_.js';
import type { TestingModule } from '@nestjs/testing';
import { HttpRequestService } from '@/core/HttpRequestService.js';
import { InternalEventService } from '@/core/InternalEventService.js';
import { DI } from '@/di-symbols.js';
describe('S3Service', () => {
let app: TestingModule;
let s3Service: S3Service;
let fakeMeta: MiMeta;
const s3Mock = mockClient(S3Client);
beforeAll(async () => {
app = await Test.createTestingModule({
imports: [GlobalModule, CoreModule],
providers: [S3Service],
}).compile();
})
.overrideProvider(InternalEventService).useClass(FakeInternalEventService)
.compile();
app.enableShutdownHooks();
s3Service = app.get<S3Service>(S3Service);
});
beforeEach(async () => {
s3Mock.reset();
fakeMeta = Object.create(app.get<MiMeta>(DI.meta));
s3Service = new S3Service(fakeMeta, app.get(HttpRequestService), app.get(InternalEventService));
});
afterAll(async () => {
@ -45,8 +54,9 @@ describe('S3Service', () => {
describe('upload', () => {
test('upload a file', async () => {
s3Mock.on(PutObjectCommand).resolves({});
fakeMeta.objectStorageRegion = 'us-east-1';
await s3Service.upload({ objectStorageRegion: 'us-east-1' } as MiMeta, {
await s3Service.upload({
Bucket: 'fake',
Key: 'fake',
Body: 'x',
@ -58,7 +68,7 @@ describe('S3Service', () => {
s3Mock.on(UploadPartCommand).resolves({ ETag: '1' });
s3Mock.on(CompleteMultipartUploadCommand).resolves({ Bucket: 'fake', Key: 'fake' });
await s3Service.upload({} as MiMeta, {
await s3Service.upload({
Bucket: 'fake',
Key: 'fake',
Body: 'x'.repeat(8 * 1024 * 1024 + 1), // デフォルトpartSizeにしている 8 * 1024 * 1024 を越えるサイズ
@ -67,22 +77,23 @@ describe('S3Service', () => {
test('upload a file error', async () => {
s3Mock.on(PutObjectCommand).rejects({ name: 'Fake Error' });
fakeMeta.objectStorageRegion = 'us-east-1';
await expect(s3Service.upload({ objectStorageRegion: 'us-east-1' } as MiMeta, {
await expect(s3Service.upload({
Bucket: 'fake',
Key: 'fake',
Body: 'x',
})).rejects.toThrowError(Error);
})).rejects.toThrow();
});
test('upload a large file error', async () => {
s3Mock.on(UploadPartCommand).rejects();
await expect(s3Service.upload({} as MiMeta, {
await expect(s3Service.upload({
Bucket: 'fake',
Key: 'fake',
Body: 'x'.repeat(8 * 1024 * 1024 + 1), // デフォルトpartSizeにしている 8 * 1024 * 1024 を越えるサイズ
})).rejects.toThrowError(Error);
})).rejects.toThrow();
});
});
});