From 7c6f46a3e0765503cb49be625bb383f424e0d608 Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Wed, 1 Oct 2025 11:57:46 -0400 Subject: [PATCH] remove NestJS instance from NoteCreateService.ts tests --- .../backend/test/unit/NoteCreateService.ts | 49 ++++++------------- 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/packages/backend/test/unit/NoteCreateService.ts b/packages/backend/test/unit/NoteCreateService.ts index 1b14f810e9..2869dcc5af 100644 --- a/packages/backend/test/unit/NoteCreateService.ts +++ b/packages/backend/test/unit/NoteCreateService.ts @@ -3,31 +3,12 @@ * SPDX-License-Identifier: AGPL-3.0-only */ -import { Test, TestingModule } from '@nestjs/testing'; - -import { CoreModule } from '@/core/CoreModule.js'; -import { NoteCreateService } from '@/core/NoteCreateService.js'; -import { GlobalModule } from '@/GlobalModule.js'; +import { isRenote, isQuote } from '@/core/NoteCreateService.js'; import { MiNote } from '@/models/Note.js'; import { IPoll } from '@/models/Poll.js'; import { MiDriveFile } from '@/models/DriveFile.js'; describe('NoteCreateService', () => { - let app: TestingModule; - let noteCreateService: NoteCreateService; - - beforeAll(async () => { - app = await Test.createTestingModule({ - imports: [GlobalModule, CoreModule], - }).compile(); - app.enableShutdownHooks(); - noteCreateService = app.get(NoteCreateService); - }); - - afterAll(async () => { - await app.close(); - }); - describe('is-renote', () => { const base: MiNote = { id: 'some-note-id', @@ -114,43 +95,45 @@ describe('NoteCreateService', () => { test('note without renote should not be Renote', () => { const note = { renote: null }; - expect(noteCreateService['isRenote'](note)).toBe(false); + expect(isRenote(note)).toBe(false); }); test('note with renote should be Renote and not be Quote', () => { const note = { renote: base }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(false); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(false); }); test('note with renote and text should be Quote', () => { const note = { renote: base, text: 'some-text' }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(true); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(true); }); test('note with renote and cw should be Quote', () => { const note = { renote: base, cw: 'some-cw' }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(true); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(true); }); test('note with renote and reply should be Quote', () => { const note = { renote: base, reply: { ...base, id: 'another-note-id' } }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(true); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(true); }); test('note with renote and poll should be Quote', () => { const note = { renote: base, poll }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(true); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(true); }); test('note with renote and non-empty files should be Quote', () => { const note = { renote: base, files: [file] }; - expect(noteCreateService['isRenote'](note)).toBe(true); - expect(noteCreateService['isQuote'](note)).toBe(true); + expect(isRenote(note)).toBe(true); + expect(isQuote(note)).toBe(true); }); }); + + // TODO tests for isPureRenote });