remerge: remove FetchAllowSoftFailMask in favor of our same-authority checks
This commit is contained in:
parent
82e2952e3c
commit
7ea710b314
10 changed files with 86 additions and 111 deletions
|
|
@ -2,7 +2,6 @@
|
|||
* SPDX-FileCopyrightText: syuilo and misskey-project
|
||||
* SPDX-License-Identifier: AGPL-3.0-only
|
||||
*/
|
||||
|
||||
process.env.NODE_ENV = 'test';
|
||||
|
||||
import * as assert from 'assert';
|
||||
|
|
|
|||
|
|
@ -8,7 +8,6 @@ import httpSignature from '@peertube/http-signature';
|
|||
|
||||
import { genRsaKeyPair } from '@/misc/gen-key-pair.js';
|
||||
import { ApRequestCreator } from '@/core/activitypub/ApRequestService.js';
|
||||
import { assertActivityMatchesUrl, FetchAllowSoftFailMask } from '@/core/activitypub/misc/check-against-url.js';
|
||||
import { IObject } from '@/core/activitypub/type.js';
|
||||
|
||||
export const buildParsedSignature = (signingString: string, signature: string, algorithm: string) => {
|
||||
|
|
@ -65,6 +64,7 @@ describe('ap-request', () => {
|
|||
assert.deepStrictEqual(result, true);
|
||||
});
|
||||
|
||||
/*
|
||||
test('rejects non matching domain', () => {
|
||||
assert.doesNotThrow(() => assertActivityMatchesUrl(
|
||||
'https://alice.example.com/abc',
|
||||
|
|
@ -78,7 +78,7 @@ describe('ap-request', () => {
|
|||
'https://alice.example.com/abc',
|
||||
FetchAllowSoftFailMask.Any,
|
||||
), 'validation should fail no matter what if the response URL is inconsistent with the object ID');
|
||||
|
||||
|
||||
assert.doesNotThrow(() => assertActivityMatchesUrl(
|
||||
'https://alice.example.com/abc#test',
|
||||
{ id: 'https://alice.example.com/abc' } as IObject,
|
||||
|
|
@ -168,4 +168,5 @@ describe('ap-request', () => {
|
|||
FetchAllowSoftFailMask.Strict,
|
||||
), 'throws if HTTP downgrade is detected');
|
||||
});
|
||||
*/
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue