misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

build role schema validators early

Browse source 
there is really no good reason to build them on-demand

also, this way, if the schema itself is invalid, we get the error
thrown at startup, not the first time we try to use one of the role
endpoints
This commit is contained in:
dakkar 2025-07-24 16:52:36 +01:00 • committed by Hazelnoot
parent ce68485684
commit 8773ddebe3
1 changed files with 9 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

28
packages/backend/src/core/RoleService.ts
View file

@ -186,7 +186,7 @@ const RoleSchema: JSONSchemaType<MiRole['policies']> = {
[policy, value]: [string, JSONSchemaType<RolePolicies>['properties']['canTrend']]
) => {
return [
policy as string,
policy,
{
type: 'object',
additionalProperties: false,
@ -252,6 +252,14 @@ export class RoleService implements OnApplicationShutdown, OnModuleInit {
// TODO additional cache for final calculation?
this.redisForSub.on('message', this.onMessage);
// this is copied from server/api/endpoint-base.ts
const ajv = new Ajv.default({
useDefaults: true,
allErrors: true,
});
this.defaultPoliciesValidator = ajv.compile(DefaultPoliciesSchema);
this.roleValidator = ajv.compile(RoleSchema);
}
@bindThis
@ -937,15 +945,6 @@ export class RoleService implements OnApplicationShutdown, OnModuleInit {
public assertValidRole(role: Partial<MiRole>): void {
if (!role.policies) return;
if (!this.roleValidator) {
// this is copied from server/api/endpoint-base.ts
const ajv = new Ajv.default({
useDefaults: true,
allErrors: true,
});
this.roleValidator = ajv.compile(RoleSchema);
}
if (this.roleValidator(role.policies)) return;
throw new IdentifiableError(
@ -958,15 +957,6 @@ export class RoleService implements OnApplicationShutdown, OnModuleInit {
@bindThis
public assertValidDefaultPolicies(policies: object): void {
if (!this.defaultPoliciesValidator) {
// this is copied from server/api/endpoint-base.ts
const ajv = new Ajv.default({
useDefaults: true,
allErrors: true,
});
this.defaultPoliciesValidator = ajv.compile(DefaultPoliciesSchema);
}
if (this.defaultPoliciesValidator(policies)) return;
throw new IdentifiableError(