misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

separate get into get and getMaybe

Browse source
This commit is contained in:
Hazelnoot 2025-11-12 00:48:58 -05:00
parent a1265f4c45
commit a2ddeb28c3
3 changed files with 43 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/backend/src/core/CacheService.ts
View file

@ -553,7 +553,7 @@ export class CacheService implements OnApplicationShutdown {
for (const uid of userIds) {
const toAdd: MiUser[] = [];
const userById = this.userByIdCache.get(uid);
const userById = this.userByIdCache.getMaybe(uid);
if (userById) toAdd.push(userById);
if (toAdd.length > 0) {
@ -670,9 +670,9 @@ export class CacheService implements OnApplicationShutdown {
// TODO should we filter for local/remote events?
switch (type) {
case 'follow': {
const follower = this.userByIdCache.get(body.followerId);
const follower = this.userByIdCache.getMaybe(body.followerId);
if (follower) follower.followingCount++;
const followee = this.userByIdCache.get(body.followeeId);
const followee = this.userByIdCache.getMaybe(body.followeeId);
if (followee) followee.followersCount++;
await Promise.all([
this.userFollowingsCache.delete(body.followerId),
@ -683,9 +683,9 @@ export class CacheService implements OnApplicationShutdown {
break;
}
case 'unfollow': {
const follower = this.userByIdCache.get(body.followerId);
const follower = this.userByIdCache.getMaybe(body.followerId);
if (follower) follower.followingCount--;
const followee = this.userByIdCache.get(body.followeeId);
const followee = this.userByIdCache.getMaybe(body.followeeId);
if (followee) followee.followersCount--;
await Promise.all([
this.userFollowingsCache.delete(body.followerId),
@ -860,7 +860,7 @@ export class CacheService implements OnApplicationShutdown {
const followeeId = typeof(followee) === 'string' ? followee : followee.id;
// This lets us use whichever one is in memory, falling back to DB fetch via userFollowingsCache.
return this.userFollowersCache.get(followeeId)?.has(followerId)
return this.userFollowersCache.getMaybe(followeeId)?.has(followerId)
?? (await this.userFollowingsCache.fetch(followerId)).has(followeeId);
}

22
packages/backend/src/misc/QuantumKVCache.ts
View file

@ -375,12 +375,24 @@ export class QuantumKVCache<TIn, T extends Value<TIn> = Value<TIn>> implements I
}
/**
* Gets a value from the local memory cache, or returns undefined if not found.
* Gets a value from the local memory cache, or throws KeyNotFoundError if not found.
* Returns cached data only - does not make any fetches.
* TODO separate get/getMaybe
*/
@bindThis
public get(key: string): T | undefined {
public get(key: string): T {
const result = this.getMaybe(key);
if (result === undefined) {
throw new KeyNotFoundError(this.nameForError, key);
}
return result;
}
/**
* Gets a value from the local memory cache, or returns undefined if not found.
* Returns cached data only - does not make any fetches.
*/
@bindThis
public getMaybe(key: string): T | undefined {
return this.memoryCache.get(key);
}
@ -393,7 +405,7 @@ export class QuantumKVCache<TIn, T extends Value<TIn> = Value<TIn>> implements I
public getMany(keys: Iterable<string>): [key: string, value: T | undefined][] {
const results: [key: string, value: T | undefined][] = [];
for (const key of keys) {
results.push([key, this.get(key)]);
results.push([key, this.getMaybe(key)]);
}
return results;
}
@ -460,7 +472,7 @@ export class QuantumKVCache<TIn, T extends Value<TIn> = Value<TIn>> implements I
// Spliterate into cached results / uncached keys.
for (const key of keys) {
const fromCache = this.get(key);
const fromCache = this.getMaybe(key);
if (fromCache) {
results.push([key, fromCache]);
} else {

21
packages/backend/test/unit/misc/QuantumKVCacheTests.ts
View file

@ -220,10 +220,29 @@ describe(QuantumKVCache, () => {
expect(result).toBe('bar');
});
it('should throw KeyNotFoundError if missing', () => {
const cache = makeCache<string>();
assert.throws(KeyNotFoundError, () => {
cache.get('foo');
});
});
});
describe('getMaybe', () => {
it('should return value if present', async () => {
const cache = makeCache<string>();
await cache.set('foo', 'bar');
const result = cache.getMaybe('foo');
expect(result).toBe('bar');
});
it('should return undefined if missing', () => {
const cache = makeCache<string>();
const result = cache.get('foo');
const result = cache.getMaybe('foo');
expect(result).toBe(undefined);
});