From b1021b3518904a1bcbb06cd9e5ffddc35a2fb5ed Mon Sep 17 00:00:00 2001 From: dakkar Date: Sun, 3 Aug 2025 13:33:27 +0100 Subject: [PATCH] more sensible variable names thanks Hazelnoot --- packages/backend/src/core/UtilityService.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/backend/src/core/UtilityService.ts b/packages/backend/src/core/UtilityService.ts index a19203ef4c..11606e3184 100644 --- a/packages/backend/src/core/UtilityService.ts +++ b/packages/backend/src/core/UtilityService.ts @@ -223,8 +223,8 @@ export class UtilityService { @bindThis public isDeliverSuspendedSoftware(software: Pick): SoftwareSuspension | undefined { // a missing name or version is treated as the empty string - const instanceName = software.softwareName ?? ''; - const instanceVersion = software.softwareVersion ?? ''; + const softwareName = software.softwareName ?? ''; + const softwareVersion = software.softwareVersion ?? ''; function maybeRegexpMatch(test: string, target: string): boolean { const regexpStrPair = test.trim().match(/^\/(.+)\/(.*)$/); @@ -244,12 +244,12 @@ export class UtilityService { x => ( ( x.software.trim() === '*' || - x.software === instanceName || - maybeRegexpMatch(x.software, instanceName) + x.software === softwareName || + maybeRegexpMatch(x.software, softwareName) ) && ( x.versionRange.trim() === '*' || - semver.satisfies(instanceVersion, x.versionRange, { includePrerelease: true }) || - maybeRegexpMatch(x.versionRange, instanceVersion) + semver.satisfies(softwareVersion, x.versionRange, { includePrerelease: true }) || + maybeRegexpMatch(x.versionRange, softwareVersion) ) ) );