misty.cafe/mistykey
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

merge: remove mousemove callback when there's no longer a cat - fix #1158 (!1198)

Browse source 
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1198

Closes #1158

Approved-by: Hazelnoot <acomputerdog@gmail.com>
Approved-by: Marie <github@yuugi.dev>
This commit is contained in:
Marie 2025-07-30 18:50:40 +00:00
commit b9f96c259f
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
packages/frontend/src/components/SkOneko.vue
View file

@ -13,7 +13,7 @@ Displays Oneko, a cat that follows the cursor.
// oneko.js: https://github.com/adryd325/oneko.js
// modified to be a vue component by ShittyKopper :3
import { shallowRef, onMounted } from 'vue';
import { shallowRef, onMounted, onUnmounted } from 'vue';
const nekoEl = shallowRef<HTMLDivElement>();
@ -93,21 +93,26 @@ const spriteSets = {
],
};
function mouseCallback(event) {
mousePosX = event.clientX;
mousePosY = event.clientY;
}
function init() {
if (!nekoEl.value) return;
nekoEl.value.style.left = `${nekoPosX - 16}px`;
nekoEl.value.style.top = `${nekoPosY - 16}px`;
// TODO this causes a memory leak because it never gets unbound
window.document.addEventListener('mousemove', (event) => {
mousePosX = event.clientX;
mousePosY = event.clientY;
});
window.document.addEventListener('mousemove', mouseCallback, { passive: true });
window.requestAnimationFrame(onAnimationFrame);
}
function uninit() {
window.removeEventListener('mousemove', mouseCallback, { passive: true });
}
function onAnimationFrame(timestamp) {
// Stops execution if the neko element is removed from DOM
if (!nekoEl.value?.isConnected) {
@ -232,6 +237,7 @@ function frame() {
}
onMounted(init);
onUnmounted(uninit);
</script>
<style module>