From bc1cd86b108274965e412006f8105bca5af2f48b Mon Sep 17 00:00:00 2001 From: dakkar Date: Tue, 13 May 2025 15:29:38 +0100 Subject: [PATCH] fix `test/e2e/blocks.ts` by adding a note visibility check on the backend --- packages/backend/src/server/api/endpoints/notes/create.ts | 2 ++ packages/backend/test/e2e/block.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/server/api/endpoints/notes/create.ts b/packages/backend/src/server/api/endpoints/notes/create.ts index 3dd90c3dca..ac1c9bfad9 100644 --- a/packages/backend/src/server/api/endpoints/notes/create.ts +++ b/packages/backend/src/server/api/endpoints/notes/create.ts @@ -302,6 +302,8 @@ export default class extends Endpoint { // eslint- throw new ApiError(meta.errors.noSuchRenoteTarget); } else if (isRenote(renote) && !isQuote(renote)) { throw new ApiError(meta.errors.cannotReRenote); + } else if (!await this.noteEntityService.isVisibleForMe(renote, me.id)) { + throw new ApiError(meta.errors.cannotRenoteDueToVisibility); } // Check blocking diff --git a/packages/backend/test/e2e/block.ts b/packages/backend/test/e2e/block.ts index 35b0e59383..bb25c9e434 100644 --- a/packages/backend/test/e2e/block.ts +++ b/packages/backend/test/e2e/block.ts @@ -53,7 +53,7 @@ describe('Block', () => { assert.strictEqual(res.status, 400); assert.ok(res.body); - assert.strictEqual(castAsError(res.body).error.id, 'b390d7e1-8a5e-46ed-b625-06271cafd3d3'); + assert.strictEqual(castAsError(res.body).error.id, 'b98980fa-3780-406c-a935-b6d0eeee10d1'); }); test('ブロックされているユーザーのノートをRenoteできない', async () => { @@ -62,7 +62,7 @@ describe('Block', () => { const res = await api('notes/create', { renoteId: note.id, text: 'yo' }, bob); assert.strictEqual(res.status, 400); - assert.strictEqual(castAsError(res.body).error.id, 'b390d7e1-8a5e-46ed-b625-06271cafd3d3'); + assert.strictEqual(castAsError(res.body).error.id, 'be9529e9-fe72-4de0-ae43-0b363c4938af'); }); // TODO: ユーザーリストに入れられないテスト