From df0f68251803de1e7f38cde2998a81169dc1df29 Mon Sep 17 00:00:00 2001 From: dakkar Date: Wed, 23 Jul 2025 10:46:01 +0100 Subject: [PATCH] make `trustedDomains` persist across reloads we can't just write to `prefer.s.*`, we need to `.commit` also, there's no need to use the reactive view (`prefer.r.*`) in non-reactive contexts --- packages/frontend/src/components/MkUrlWarningDialog.vue | 2 +- packages/frontend/src/utility/warning-external-website.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/frontend/src/components/MkUrlWarningDialog.vue b/packages/frontend/src/components/MkUrlWarningDialog.vue index 01ecba1817..8b18942719 100644 --- a/packages/frontend/src/components/MkUrlWarningDialog.vue +++ b/packages/frontend/src/components/MkUrlWarningDialog.vue @@ -64,7 +64,7 @@ function done(canceled: boolean, result?: Result): void { // eslint-disable-line async function ok() { const result = true; if (!prefer.s.trustedDomains.includes(domain.value) && trustThisDomain.value) { - prefer.r.trustedDomains.value = prefer.s.trustedDomains.concat(domain.value); + prefer.commit('trustedDomains', prefer.s.trustedDomains.concat(domain.value)); } done(false, result); } diff --git a/packages/frontend/src/utility/warning-external-website.ts b/packages/frontend/src/utility/warning-external-website.ts index 33cf379b50..28c03c419d 100644 --- a/packages/frontend/src/utility/warning-external-website.ts +++ b/packages/frontend/src/utility/warning-external-website.ts @@ -36,8 +36,8 @@ export async function warningExternalWebsite(url: string) { } }); - const isTrustedByUser = prefer.r.trustedDomains.value.includes(hostname); - const isDisabledByUser = !prefer.r.warnExternalUrl.value; + const isTrustedByUser = prefer.s.trustedDomains.includes(hostname); + const isDisabledByUser = !prefer.s.warnExternalUrl; if (!isTrustedByInstance && !isTrustedByUser && !isDisabledByUser) { const confirm = await new Promise<{ canceled: boolean }>(resolve => {