Commit graph

10137 commits

Author SHA1 Message Date
Hazelnoot
b38351e28a add workarounds for node-fetch crashes 2025-07-21 16:16:33 -04:00
Hazelnoot
1758b5b3be fix URL errors from incorrect validation in validateActor 2025-07-21 16:16:33 -04:00
Hazelnoot
48fa42b362 re-use parsed URI in validateActor 2025-07-21 16:16:33 -04:00
Hazelnoot
ba9ec3bcee verify URLs in DownloadService 2025-07-21 16:16:33 -04:00
Hazelnoot
dac310b540 use shared URL verification in verifyLinkFields 2025-07-21 16:16:32 -04:00
Hazelnoot
15f6c6ca93 validate all URLs before fetch 2025-07-21 16:16:32 -04:00
Hazelnoot
f163e15602 move user.lastFetchedAt to UserLite 2025-07-21 16:13:00 -04:00
Hazelnoot
69402e3abb move user.updateAt to UserLite 2025-07-21 16:13:00 -04:00
Hazelnoot
3dbfb4fa20 add "detail" flag to more user endpoints 2025-07-21 16:13:00 -04:00
Hazelnoot
34dcb1c51c optimize i/update-remote-user endpoint by fetching from cache 2025-07-21 16:12:32 -04:00
Hazelnoot
5a9bf50424 increase rate limit for import endpoints to 1 per minute 2025-07-21 16:12:19 -04:00
Hazelnoot
d2ec40fb87 scale rate limit dripRate with factor 2025-07-21 15:57:30 -04:00
Hazelnoot
c190dfa6bc fix incorrect error logging in UrlPreviewService 2025-07-21 15:56:17 -04:00
Hazelnoot
ec44c44ca4 fix incorrect error logging in ApPersonService 2025-07-21 15:56:17 -04:00
Hazelnoot
2b7c74c63c include profile URI for link verification 2025-07-21 15:55:36 -04:00
Hazelnoot
4346bac05f check for null jobs in QueueService.queueGetJobs 2025-07-21 15:55:00 -04:00
Hazelnoot
223198a0fb fix admin/delete-all-files-of-a-user endpoint recording a log entry for every single file 2025-07-21 15:54:49 -04:00
Hazelnoot
ed68230811 merge: Add importCompleted notification. Send importCompleted when antenna/customEmoji/muting/userList is imported (!1165)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1165

Closes #891

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2025-07-21 18:42:29 +00:00
Hazelnoot
31344bb816 merge: Add docstrings for Sharkey components (!1172)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1172

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2025-07-21 15:40:30 +00:00
наб
d954b8d138
StreamingApiServerService: handle websocket errors from client gracefully
$ nc -C tarta.nabijaczleweli.xyz 12122
  GET /streaming?_t=1752534314122 HTTP/1.1
  Host: tarta.nabijaczleweli.xyz:12122
  User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:142.0) Gecko/20100101 Firefox/142.0
  Accept: */*
  Accept-Language: en-GB,en;q=0.5
  Accept-Encoding: gzip, deflate
  Sec-WebSocket-Version: 13
  Sec-WebSocket-Extensions: permessage-deflate
  Sec-WebSocket-Key: AAAAAAAAAAAAAAAAAAAAAA==
  Connection: keep-alive, Upgrade
  Pragma: no-cache
  Cache-Control: no-cache
  Upgrade: websocket
the parameters almost don't matter so long as the server
replies with an upgrade, then press enter once or twice,
at which point the server will have crashed after
  INFO 1  [core nest]             NestFactory: Starting Nest application...
  ERR  *  [core]          Uncaught exception (uncaughtException): RangeError: Invalid WebSocket frame: invalid opcode 13
      at Receiver.getInfo (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:311:26)
      at Receiver.startLoop (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:155:16)
      at Receiver._write (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:94:10)
      at writeOrBuffer (node:internal/streams/writable:572:12)
      at _write (node:internal/streams/writable:501:10)
      at Writable.write (node:internal/streams/writable:510:10)
      at Socket.socketOnData (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/websocket.js:1355:35)
      at Socket.emit (node:events:518:28)
      at addChunk (node:internal/streams/readable:561:12)
      at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
      at Readable.push (node:internal/streams/readable:392:5)
      at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
    code: 'WS_ERR_INVALID_OPCODE',
    [Symbol(status-code)]: 1002
  }
  INFO *  [core]          The process is going to exit with code 1
  node:events:496
        throw er; // Unhandled 'error' event
        ^

  RangeError: Invalid WebSocket frame: invalid opcode 13
      at Receiver.getInfo (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:311:26)
      at Receiver.startLoop (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:155:16)
      at Receiver._write (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/receiver.js:94:10)
      at writeOrBuffer (node:internal/streams/writable:572:12)
      at _write (node:internal/streams/writable:501:10)
      at Writable.write (node:internal/streams/writable:510:10)
      at Socket.socketOnData (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/websocket.js:1355:35)
      at Socket.emit (node:events:518:28)
      at addChunk (node:internal/streams/readable:561:12)
      at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
      at Readable.push (node:internal/streams/readable:392:5)
      at TCP.onStreamRead (node:internal/stream_base_commons:189:23)
  Emitted 'error' event on WebSocket instance at:
      at Receiver.receiverOnError (/srv/Sharkey/node_modules/.pnpm/ws@8.18.1_bufferutil@4.0.9_utf-8-validate@6.0.5/node_modules/ws/lib/websocket.js:1199:15)
      at Receiver.emit (node:events:518:28)
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    code: 'WS_ERR_INVALID_OPCODE',
    [Symbol(status-code)]: 1002
  }

  Node.js v22.14.0
   ELIFECYCLE  Command failed with exit code 1.

This works through some reverse proxies (HAProxy, Caddy),
but not through others (Cloudflare, nginx, Apache(?))

Instead, just hang up if the client violates protocol

Fixes https://101010.pl/@nabijaczleweli/114854334401159070
2025-07-21 17:39:41 +02:00
Hazelnoot
6d73171dfe merge: Reject duplicate mod actions (!1157)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/1157

Closes #768

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2025-07-21 14:59:49 +00:00
bunnybeam
705e65e2d2
clarify that SkNote files are in the Sharkey style 2025-07-17 21:31:46 +01:00
bunnybeam
ff477e3bc7
changes to docstrings based on feedback 2025-07-17 21:28:17 +01:00
Vavency
8864269d7c [frontend] SkModPlayer Minor cleanup
Hide the shame of webkit.
2025-07-17 21:36:26 +03:00
bunnybeam
184d116632
add docstrings for components beginning with Sk, along with DynamicNotes 2025-07-17 17:38:45 +01:00
Vavency
30316e543c [frontend] SkModPlayer CSS adjustment. 2025-07-17 19:17:13 +03:00
Vavency
13b22cb70b [frontend] SkModPlayer change number row from maxHeight to height to fix early clipping. 2025-07-17 18:50:14 +03:00
dakkar
8b1a0f1226 replace URL path for inlined SearchMarkers - fixes #1154
The search index looks like:

```ts
[
 {
   id: 'foo', label: 'security',
   path: '/settings/security', inlining: ['2fa'],
 },
 {
   id: '2fa',
   label: 'two-factor auth',
   path: '/settings/2fa', // guessed wrong by the index generation
 },
 {
   id: 'aaaa',
   parentId: '2fa',
   label: 'totp',
 },
 …
]
```

This file post-processes that index and re-parents the inlined
sections. Problem was, it left the (wrong) `path` untouched.

Replacing the `path` makes the search work fine.
2025-07-17 16:36:50 +01:00
Vavency
9dbd2a6bb4 Merge branch Sharkey:develop into trackeropt 2025-07-17 15:04:33 +00:00
Vavency
4ae3d7453b [frontend] SkModPlayer fix togglePattern not properly skipping optimizations. 2025-07-17 18:02:10 +03:00
Vavency
d61b1e2910 [frontend] SkModPlayer fix toggleVisible completely breaking display. 2025-07-17 14:34:51 +03:00
Vavency
89d396b491 [frontend] SkModPlayer better handling of different display sizes. 2025-07-17 13:43:49 +03:00
Vavency
dfc2e2a9a7 [frontend] SkModPlayer implement webkit scroll hack. 2025-07-17 13:10:04 +03:00
Vavency
046cb125f2 [frontend] SkModPlayer stop a potential infinite nextTick recursion. 2025-07-16 22:19:27 +03:00
Vavency
912f5eb44b [frontend] SkModPlayer fix currentColumn not updating. 2025-07-16 22:08:39 +03:00
Vavency
7f30afd4fd [frontend] SkModPlayer remove old webkit workaround for scrollbars
Fix for channel jumps at the end of x scroll.
2025-07-16 21:19:27 +03:00
Emily Fox
b58bd4b9c9 prevent mastodon api error when not fetching reply or renote (resolves #1125)
Use of inner joins for `reply.user` and `renote.user` meant fetching a base
note would always fail when asked to query reply or renote information.
2025-07-16 12:07:38 -05:00
наб
6abbf955fc
Uniquify exportEntityName and importEntityName 2025-07-16 18:32:19 +02:00
наб
a00a3c6841
Add importCompleted notification. Send importCompleted when antenna/customEmoji/muting/userList is imported
The only userImportableEntities that don't notify
are blocking and following because they fork off a batch of single

Closes #891
2025-07-16 18:32:18 +02:00
piuvas
c97fafa071
requested changes. 2025-07-16 12:43:35 -03:00
Hazelnoot
38616ab246 disable outgoing mastodon quotes 2025-07-16 10:58:05 +01:00
piuvas
1696e31797
initial split descriptions impl. 2025-07-15 18:37:29 -03:00
bunnybeam
55022826cf
consistent styling for duplicate mod action checks 2025-07-14 19:40:04 +01:00
bunnybeam
92d87f955f
remove index on confetti column 2025-07-14 19:32:42 +01:00
Vavency
848d1dea88 [frontend] SkModPlayer fix vertical alignment on non-standart view heights 2025-07-11 15:03:54 +03:00
bunnybeam
0191ea8844
fix admin/unnsfw-user not working 2025-07-10 22:49:00 +01:00
Vavency
b26f777ae7 [frontend] SkModPlayer fix webkit scrolling. 2025-07-10 22:48:42 +03:00
bunnybeam
eca81b6494
add various checks to avoid duplicate mod actions 2025-07-10 18:29:57 +01:00
bunnybeam
d023fb3389
return instead of erroring when suspending a suspended user 2025-07-10 16:19:55 +01:00
bunnybeam
7581b5b40b
prevent suspending a user who is already suspended 2025-07-10 15:45:21 +01:00