かっこかり
c4192e81ed
enhance(backend): チャートの処理を一つずつ行うことでDBの同時接続とタイムアウトを削減 ( #15239 )
...
* sync charts one-at-a-time to reduce database contention and timeouts
* fix merge resolve failure
* Update Changelog
* update changelog
* add comments
---------
Co-authored-by: Hazelnoot <acomputerdog@gmail.com>
2025-01-11 13:43:42 +00:00
dakkar
f4aa986abd
fix scheduled replies becoming quote-boosts
...
thanks to @CenTdemeern1 for triggering this bug!
see https://kitsunes.club/notes/a2h1y2rq9n
also compare with https://s.thenautilus.net/notes/a2h1y2rqx9
my instance errored out with:
> WARN 1 [remote ap] Failed to resolve quote
> https://mastodon.social/users/DrALJONES/statuses/110586222749407429
> for note https://kitsunes.club/notes/a2h1y2rq9n : StatusError: 404 Not
> Found
What happened?
* Charlotte scheduled a reply
* the processor called `findOneBy` with an undefined `note.renote`,
which probably caused a `select` without any `where`
* a random note was attached as a quote
* that note has been deleted on the original instance but not on
kitsuclub's database
* the rest of fedi didn't notice the quote
2025-01-01 17:10:56 +00:00
Hazelnoot
abb2c37591
re-implement "reduce inbox log spam when fetching blocked / unavailable notes"
2024-12-22 15:28:28 -05:00
dakkar
e4047b4076
rethrow everything but non-retryable HTTP errors
...
every job that ends without an exception will be considered
"completed" and not retried
2024-12-22 15:28:21 -05:00
Hazelnoot
0b40f2734e
sync charts one-at-a-time to reduce database contention and timeouts
2024-12-17 10:37:29 -05:00
dakkar
6d4ae93592
Merge branch 'develop' into feature/2024.10
2024-12-12 13:04:51 +00:00
Marie
bf01dcd8fb
Apply suggestions
2024-12-09 18:58:57 +01:00
Marie
152cc07483
Apply suggestions
2024-12-09 05:58:25 +01:00
Marie
1d3c825398
upd: add notification for when scheduled note gets posted
2024-12-09 05:33:19 +01:00
Marie
fc9d777dc3
upd: add notification for failures, add reasons for failure, apply suggestions
2024-12-09 05:32:51 +01:00
NoriDev
2528508cff
feat: 노트 게시를 예약할 수 있음 ( yojo-art/cherrypick#483 , [ Type4ny-Project/Type4ny@271c872c ]( 271c872c97))
2024-12-09 05:31:03 +01:00
dakkar
66dd12fb8a
Merge branch 'develop' into feature/2024.10
2024-11-29 11:42:47 +00:00
Hazelnoot
536060e63c
merge: Clear jobs from blocked domains ( resolves #773 ) ( !720 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/720
Closes #773
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
2024-11-29 10:29:27 +00:00
dakkar
eb25238a8e
Merge branch 'develop' into feature/2024.10
2024-11-28 11:17:27 +00:00
Hazelnoot
1e99782666
allow anonymous activities ( resolves #819 )
2024-11-26 09:05:04 -05:00
Hazelnoot
3f5ea11a1f
clarify logging when an inbox job is skipped or fails
2024-11-26 08:59:08 -05:00
dakkar
6c13dc04f2
Merge branch 'develop' into feature/2024.10
2024-11-23 10:41:33 +00:00
Hazelnoot
2bbccde2ce
reduce inbox log spam when fetching blocked / unavailable notes
2024-11-22 09:16:03 -05:00
dakkar
585052646a
better wording for moderator inactivity messages
2024-11-22 10:49:16 +00:00
dakkar
d069d78c21
Merge branch 'develop' into feature/2024.10
2024-11-22 10:42:58 +00:00
Julia Johannesen
23c4aa2571
Fix style error
2024-11-20 20:24:59 -05:00
Laura Hausmann
ad8e8793c7
fix: primitives 5 & 8: reject activities with non-string identifiers
2024-11-20 19:17:24 -05:00
Julia
5f675201f2
Merge commit from fork
...
* enhance: Add a few validation fixes from Sharkey
See the original MR on the GitLab instance:
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/484
Co-Authored-By: Dakkar <dakkar@thenautilus.net>
* fix: primitive 2: acceptance of cross-origin alternate
Co-Authored-By: Laura Hausmann <laura@hausmann.dev>
* fix: primitive 3: validation of non-final url
* fix: primitive 4: missing same-origin identifier validation of collection-wrapped activities
* fix: primitives 5 & 8: reject activities with non
string identifiers
Co-Authored-By: Laura Hausmann <laura@hausmann.dev>
* fix: primitive 6: reject anonymous objects that were fetched by their id
* fix: primitives 9, 10 & 11: http signature validation
doesn't enforce required headers or specify auth header name
Co-Authored-By: Laura Hausmann <laura@hausmann.dev>
* fix: primitive 14: improper validation of outbox, followers, following & shared inbox collections
* fix: code style for primitive 14
* fix: primitive 15: improper same-origin validation for
note uri and url
Co-Authored-By: Laura Hausmann <laura@hausmann.dev>
* fix: primitive 16: improper same-origin validation for user uri and url
* fix: primitive 17: note same-origin identifier validation can be bypassed by wrapping the id in an array
* fix: code style for primitive 17
* fix: check attribution against actor in notes
While this isn't strictly required to fix the exploits at hand, this
mirrors the fix in `ApQuestionService` for GHSA-5h8r-gq97-xv69, as a
preemptive countermeasure.
* fix: primitive 18: `ap/get` bypasses access checks
One might argue that we could make this one actually preform access
checks against the returned activity object, but I feel like that's a
lot more work than just restricting it to administrators, since, to me
at least, it seems more like a debugging tool than anything else.
* fix: primitive 19 & 20: respect blocks and hide more
Ideally, the user property should also be hidden (as leaving it in leaks
information slightly), but given the schema of the note endpoint, I
don't think that would be possible without introducing some kind of
"ghost" user, who is attributed for posts by users who have you blocked.
* fix: primitives 21, 22, and 23: reuse resolver
This also increases the default `recursionLimit` for `Resolver`, as it
theoretically will go higher that it previously would and could possibly
fail on non-malicious collection activities.
* fix: primitives 25-33: proper local instance checks
* revert: fix: primitive 19 & 20
This reverts commit 465a9fe6591de90f78bd3d084e3c01e65dc3cf3c.
---------
Co-authored-by: Dakkar <dakkar@thenautilus.net>
Co-authored-by: Laura Hausmann <laura@hausmann.dev>
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
2024-11-21 08:20:09 +09:00
dakkar
f079edaf3c
Merge tag '2024.10.1' into feature/2024.10
2024-11-08 15:52:37 +00:00
Hazelnoot
27b502fab5
normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
2024-10-26 10:40:15 -04:00
Hazelnoot
5eb9a263e2
fix public key re-fetch logic
2024-10-26 10:40:15 -04:00
おさむのひと
33b34ad7b8
feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知 ( #14757 )
...
* feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知
* fix misskey-js.api.md
* Revert "feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知"
This reverts commit 3ab953bdf87f28411a1a10bce787a23d238cda80.
* 通知をやめてユーザ単位でのお知らせ機能に変更
* テスト用実装を戻す
* Update packages/backend/src/queue/processors/CheckModeratorsActivityProcessorService.ts
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
* fix remove empty then
---------
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
2024-10-13 20:32:12 +09:00
syuilo
ff47fef572
feat: リモートサーバーのサーバー情報を収集しないオプション ( #14634 )
...
* wip
* wip
* Update FetchInstanceMetadataService.ts
* Update FetchInstanceMetadataService.ts
* Update types.ts
2024-10-13 20:22:16 +09:00
かっこかり
2f09d69773
fix(backend): キューのエラーログを簡略化するように ( #14748 )
...
* reduce federation log spam
* Don't record stack trace for unrecoverable errors.
* Avoid logging duplicate stace traces.
(cherry picked from commit ed0570110b20dd66f73583869e1c47786702e076b4d10aa8f8f62cd8941cd8e1e4890dd867c2089b5171ba7113a5316c06ed
2024-10-11 21:29:03 +09:00
おさむのひと
a2cd6a7709
feat(backend): 7日間運営のアクティビティがないサーバを自動的に招待制にする ( #14746 )
...
* feat(backend): 7日間運営のアクティビティがないサーバを自動的に招待制にする
* fix RoleService.
* fix
* fix
* fix
* add test and fix
* fix
* fix CHANGELOG.md
* fix test
2024-10-11 20:59:36 +09:00
dakkar
02d36c4518
Merge branch 'develop' into feature/2024.9.0
2024-10-11 10:10:16 +01:00
dakkar
f00576bce6
Merge remote-tracking branch 'misskey/master' into feature/2024.9.0
2024-10-09 15:17:22 +01:00
Hazel K
a5316c06ed
don't log job name unless it has one
2024-10-08 11:01:24 -04:00
Hazel K
5171ba7113
collapse AbortErrors
2024-10-08 10:43:58 -04:00
Hazel K
d867c2089b
further condense error details
2024-10-08 10:43:51 -04:00
Hazel K
d8e1e4890d
normalize ID logging
2024-10-08 10:33:48 -04:00
Hazel K
f62cd8941c
condense error info
2024-10-08 10:33:34 -04:00
Hazel K
b4d10aa8f8
fix maxAttempts calculation
2024-10-08 10:29:03 -04:00
Hazel K
786702e076
condense job info
2024-10-08 10:27:55 -04:00
Hazel K
83869e1c47
fix lint errors
2024-10-08 10:14:33 -04:00
Hazel K
20dd66f735
improve error summaries
2024-10-08 10:14:26 -04:00
Hazel K
ed0570110b
reduce federation log spam
...
* Don't record stack trace for unrecoverable errors.
* Avoid logging duplicate stace traces.
2024-10-08 09:30:08 -04:00
かっこかり
9d026975bc
fix(backend/test): #14558 以降e2eテストがたまに失敗する問題を修正 ( #14709 )
...
* fix(backend/test): MisskeyIO#727 以降e2eテストがたまに失敗する問題を修正 (MisskeyIO#735)
* ✌️
---------
Co-authored-by: まっちゃとーにゅ <17376330+u1-liquid@users.noreply.github.com>
2024-10-05 16:20:44 +09:00
syuilo
f0d0cd2e50
wip ( #14643 )
2024-09-28 18:15:32 +09:00
かっこかり
d8a2eeb7ed
feat: エクスポート完了時に通知を発行するように ( #14484 )
...
* feat: エクスポート完了時に通知を発行するように
* Update Changelog
* entitity -> entity
* fix: ペイロードを含むように
* fix icon
* exportableEntities -> userExportableEntities
2024-09-26 14:15:03 +09:00
KOBA789
7134d24c1f
perf(backend): Defer instance metadata update ( #14558 )
...
* Defer instance metadata update
* Fix last new line
* Fix typo
* Add license notice
* Fix syntax
* Perform deferred jobs on shutdown
* Fix missing async/await
* Fix typo :)
* Update collapsed-queue.ts
---------
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
2024-09-26 10:25:20 +09:00
Aleteoryx
689848943b
Fix: Continue importing from file if single emoji import fails ( #14461 )
...
* Fix: Continue importing from file if single emoji import fails
* Fix indentation
---------
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
2024-09-24 09:50:00 +09:00
syuilo
023fa30280
refactor/perf(backend): provide metadata statically ( #14601 )
...
* wip
* Update ReactionService.ts
* Update ApiCallService.ts
* Update timeline.ts
* Update GlobalModule.ts
* Update GlobalModule.ts
* Update NoteEntityService.ts
* wip
* wip
* wip
* Update ApPersonService.ts
* wip
* Update GlobalModule.ts
* Update mock-resolver.ts
* Update RoleService.ts
* Update activitypub.ts
* Update activitypub.ts
* Update activitypub.ts
* Update activitypub.ts
* Update activitypub.ts
* clean up
* Update utils.ts
* Update UtilityService.ts
* Revert "Update utils.ts"
This reverts commit a27d4be764b78c1b5a9eac685e261fee49331d89.
* Revert "Update UtilityService.ts"
This reverts commit e5fd9e004c482cf099252201c0c1aa888e001430.
* vuwa-
* Revert "vuwa-"
This reverts commit 0c3bd12472b4b9938cdff2d6f131e6800bc3724c.
* Update entry.ts
* Update entry.ts
* Update entry.ts
* Update entry.ts
* Update jest.setup.ts
2024-09-22 12:53:13 +09:00
syuilo
0b062f1407
Misskey® Reactions Buffering Technology™ ( #14579 )
...
* wip
* wip
* Update ReactionsBufferingService.ts
* Update ReactionsBufferingService.ts
* wip
* wip
* wip
* Update ReactionsBufferingService.ts
* wip
* wip
* wip
* Update NoteEntityService.ts
* wip
* wip
* wip
* wip
* Update CHANGELOG.md
2024-09-20 21:03:53 +09:00
Hazel K
9ce44b24b8
fix(backend): memory leak in memory caches ( #14363 )
...
* encapsulate `MemoryKVCache<T>`
* remove infinity caches
* encapsulate other caches
* add missing awaits to internally synchronize caches
* implement pull-through caching
* tune cache lifetimes
* optimize cache GC by stopping early
* summarize changes in CHANGELOG.md
* Fix timeout comments
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
* add comments about awaiting the redis write
---------
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
2024-08-18 13:34:01 +09:00
